Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36090 )
Change subject: mb/google/kukui: Force DRAM retraining if hotkey pressed ......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/36090/5/src/mainboard/google/kukui/... File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/36090/5/src/mainboard/google/kukui/... PS5, Line 79: if (recovery_mode && vboot_recovery_mode_memory_retrain()) { Maybe it would be better to put all this recovery-mode handling stuff directly into the SoC code? I don't see anything mainboard-specific here, and I don't see why other mainboards would want to interpret it differently.
(There's no rule that you're not allowed to have SoC code referencing vboot stuff, it's considered a core coreboot feature now. The x86 code does it all the time... e.g. see src/soc/intel/broadwell/romstage/raminit.c.)