Attention is currently required from: Tim Wawrzynczak, Julius Werner, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56726 )
Change subject: soc/intel: Add new Kconfig INTEL_ALLOW_SOC_DEBUG_HOOKS ......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56726/comment/4a5e5644_1590e8f5 PS4, Line 9: The intent of this Kconfig is, when selected, to compile in any : Intel-specific hooks that may be available.
Well, I asked Tim to move it into soc/intel (see above).
Aah. I didn't realize that there was a discussion on the location of this config already. Humm..
It seems to be a very Intel-specific mechanism so I think that's appropriate? I still don't really know what exactly "debug hooks" refers to or how this "crashlog" works but it seems to be a completely vendor-specific mechanism?
Crashlog --> yes, that is very Intel specific. The top-level config is primarily to allow mainboard developers to simply enable a single config that will then auto-select any SoC specific debug infrastructure (Kconfigs). When I say SoC specific debug infrastructure, I am thinking of tracehubs or any other hardware debug support that a SoC provides. For Intel, it would be crashlog. For ARM platforms, it might be some other hardware controller. If you think this is something not really useful for other platforms, we can definitely start with just Intel and when required move it to a more common location.
(BTW, if this gets moved to a common location, we would need two Kconfigs and not just one i.e. SoC indicating support for debug hooks something like SOC_SUPPORTS_DEBUG_HOOKS which then allows mainboard to select ENABLE_DEBUG_HOOKS only on supported platforms).