Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31471 )
Change subject: sb/intel/i82371eb/fadt: Fix compilation on x86_64 ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/31471/2/src/southbridge/intel/i82371eb/fadt.... File src/southbridge/intel/i82371eb/fadt.c:
https://review.coreboot.org/#/c/31471/2/src/southbridge/intel/i82371eb/fadt.... PS2, Line 50: fadt->dsdt = (uintptr_t)dsdt;
We have pretty much the same in mainboard directories. […]
It depends on the destination. Some fields are 32bit only. We need to add asserts on x64 to make sure it never truncates, but that is a future cleanup.
https://review.coreboot.org/#/c/31471/2/src/southbridge/intel/i82371eb/fadt.... PS2, Line 159: fadt->x_dsdt_h = 0;
I was going to suggest what you already tried in patchset #1. […]
yes, but that's future cleanup. ATM it works for all architectures as everything is assumed to be below 4GiB.