Attention is currently required from: Arthur Heymans.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64801 )
Change subject: cpu/x86/smm_loader: Fix up headers
......................................................................
Patch Set 4:
(1 comment)
File src/cpu/x86/smm/smm_module_loader.c:
https://review.coreboot.org/c/coreboot/+/64801/comment/8ec0d209_8195b19e
PS3, Line 9: #include <stddef.h>
: #include <stdint.h>
as <stdbool.h> is needed for line #542 ,I'd include <types.h> instead […]
Oops, I mean line #544 for "const bool use_top = top_space >= bottom_space;"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64801
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ffe6d79f0656b09fe49ea0652f38b395fb08c21
Gerrit-Change-Number: 64801
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 31 May 2022 17:30:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment