Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33449 )
Change subject: soc/intel/common: Fix booting issue without default IGD enabled
......................................................................
Patch Set 2:
I think the cause of this could be a configuration issue. If
RUN_FSP_GOP is selected but the IGD disabled, it would run
into this path. Checking if the IGD is actually enabled, in
fill_lb_framebuffer() in drivers/intel/fsp2_0/graphics.c,
might be a more elegant solution.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33449
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8c907ee25db4538a84890f2ccc3187afa86604b8
Gerrit-Change-Number: 33449
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 13 Jun 2019 19:01:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment