Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46842 )
Change subject: soc/intel/jasperlake: Correct GPIO pad sequence for community pad group ......................................................................
Patch Set 7: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/46842/7/src/soc/intel/jasperlake/in... File src/soc/intel/jasperlake/include/soc/gpio_soc_defs.h:
https://review.coreboot.org/c/coreboot/+/46842/7/src/soc/intel/jasperlake/in... PS7, Line 306: #define GPIO_RSVD_24 240 : #define GPIO_RSVD_25 241 : #define GPIO_RSVD_26 242 : #define GPIO_RSVD_27 243 : #define GPIO_RSVD_28 244 : #define GPIO_RSVD_29 245 : #define GPIO_RSVD_30 246 : #define GPIO_RSVD_31 247 : #define GPIO_RSVD_32 248 : #define GPIO_RSVD_33 249 : #define GPIO_RSVD_34 250 : #define GPIO_RSVD_35 251 : #define GPIO_RSVD_36 252
Since these are the reserved at the end of the community, It won't impact the offset calculation wit […]
SG.
PS7: Maulik - can you please push the renaming of GPIOs as a separate CL? I think it will keep the changes cleaner and easier for anyone to read/review as well.
Patch 1 - Reorganize the pad groups in the communities in gpio.c Patch 2 - Rename the reserved GPIOs to use actual names and drop the ones you are currently done in COM4.