build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44715 )
Change subject: soc/mediatek/mt8192: Implement dram all channel calibration ......................................................................
Patch Set 1:
(11 comments)
https://review.coreboot.org/c/coreboot/+/44715/1/src/soc/mediatek/mt8192/dra... File src/soc/mediatek/mt8192/dramc_pi_basic_api.c:
https://review.coreboot.org/c/coreboot/+/44715/1/src/soc/mediatek/mt8192/dra... PS1, Line 4034: static void move_dramc_delay(const struct ddr_cali* cali, reg_transfer *ui, "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/44715/1/src/soc/mediatek/mt8192/dra... PS1, Line 4063: void shift_dq_ui(const struct ddr_cali* cali, u8 rk, s8 shift_ui) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/44715/1/src/soc/mediatek/mt8192/dra... PS1, Line 4069: {&ch[chn].ao.shu_rk[rk].shurk_selph_dq2, 4}}; space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/44715/1/src/soc/mediatek/mt8192/dra... PS1, Line 4073: {&ch[chn].ao.shu_rk[rk].shurk_selph_dq0, 4}}; space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/44715/1/src/soc/mediatek/mt8192/dra... PS1, Line 4493: dqs_oen_delay[1]: dqs_oen_delay[0]; spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/44715/1/src/soc/mediatek/mt8192/dra... PS1, Line 4503: ((dqs_oen_final - shift_dqs_div[1]) >> div_ratio): 0; spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/44715/1/src/soc/mediatek/mt8192/dra... PS1, Line 4532: ((dq_oen_final - shift_dq_div[1]) >> div_ratio): 0; spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/44715/1/src/soc/mediatek/mt8192/dra... PS1, Line 4577: jump_ratio[jump_ratio_index] = DIV_ROUND_CLOSEST(dst_freq * 32, src_freq); line over 96 characters
https://review.coreboot.org/c/coreboot/+/44715/1/src/soc/mediatek/mt8192/dra... PS1, Line 4603: void dramc_hmr4_presetting(const struct ddr_cali* cali) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/44715/1/src/soc/mediatek/mt8192/dra... PS1, Line 4659: void dramc_cke_debounce(const struct ddr_cali* cali) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/44715/1/src/soc/mediatek/mt8192/dra... PS1, Line 4670: void dramc_hw_dqsosc(const struct ddr_cali* cali, u8 chn) "foo* bar" should be "foo *bar"