[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: If using VBOOT, skip the APOB_NV region for RO

[Aaron Durbin (Code Review)]

Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44046 )

Change subject: soc/amd/picasso: If using VBOOT, skip the APOB_NV region for RO
......................................................................

soc/amd/picasso: If using VBOOT, skip the APOB_NV region for RO

When booting from the RO region of a VBOOT enabled ROM, there shouldn't
be a reliance on anything outside of the RO section.  This includes the
APOB_NV region (similar to the MRC cache region).  By skipping the
region when setting up the BIOS Directory table, the PSP won't try to
use the region when booting.

The APOB_NV region is still used for the VBOOT RW sections.

BUG=b:158363448
TEST=Build RO with no APOB_NV region.  Dump the BDT and verify that
it's not in RO, but is in RW_A & RW_B.  Boot into recovery.

Signed-off-by: Martin Roth 
Change-Id: I13c35ba8a2331492744d2acf257db15e4a53102a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44046
Tested-by: build bot (Jenkins) 
Reviewed-by: Aaron Durbin 
Reviewed-by: Raul Rangel 
Reviewed-by: Furquan Shaikh 
---
M src/soc/amd/picasso/Makefile.inc
1 file changed, 11 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Aaron Durbin: Looks good to me, approved
  Furquan Shaikh: Looks good to me, approved
  Raul Rangel: Looks good to me, approved

diff --git a/src/soc/amd/picasso/Makefile.inc b/src/soc/amd/picasso/Makefile.inc
index e29dbc2..f11d895 100644
--- a/src/soc/amd/picasso/Makefile.inc
+++ b/src/soc/amd/picasso/Makefile.inc
@@ -326,6 +326,11 @@
 OPT_EFS_SPI_SPEED=$(call add_opt_prefix, $(CONFIG_EFS_SPI_SPEED), --spi-speed)
 OPT_EFS_SPI_MICRON_FLAG=$(call add_opt_prefix, $(CONFIG_EFS_SPI_MICRON_FLAG), --spi-micron-flag)

+ifeq ($(CONFIG_VBOOT),)
+OPT_APOB0_NV_SIZE=$(OPT_APOB_NV_SIZE)
+OPT_APOB0_NV_BASE=$(OPT_APOB_NV_BASE)
+endif
+
 AMDFW_COMMON_ARGS=$(OPT_AMD_PUBKEY_FILE) \
    	$(OPT_PSPBTLDR_FILE) \
    	$(OPT_PSPSCUREOS_FILE) \
@@ -336,8 +341,6 @@
    	$(OPT_SMUFW2_SUB1_FILE) \
    	$(OPT_PSP_APCB_FILES) \
    	$(OPT_APOB_ADDR) \
-		$(OPT_APOB_NV_SIZE) \
-		$(OPT_APOB_NV_BASE) \
    	$(OPT_PSP_BIOSBIN_FILE) \
    	$(OPT_PSP_BIOSBIN_DEST) \
    	$(OPT_PSP_BIOSBIN_SIZE) \
@@ -465,6 +468,8 @@
    @printf "    AMDFWTOOL  $(subst $(obj)/,,$(@))\n"
    $(AMDFWTOOL) \
    	$(AMDFW_COMMON_ARGS) \
+		$(OPT_APOB0_NV_SIZE) \
+		$(OPT_APOB0_NV_BASE) \
    	--location $(shell printf "%#x" $(PICASSO_FWM_POSITION)) \
    	--output $@

@@ -479,6 +484,8 @@
    @printf "    AMDFWTOOL  $(subst $(obj)/,,$(@))\n"
    $(AMDFWTOOL) \
    	$(AMDFW_COMMON_ARGS) \
+		$(OPT_APOB_NV_SIZE) \
+		$(OPT_APOB_NV_BASE) \
    	--location $(shell printf "%#x" $(CONFIG_PICASSO_FW_A_POSITION)) \
    	--anywhere \
    	--output $@
@@ -488,6 +495,8 @@
    @printf "    AMDFWTOOL  $(subst $(obj)/,,$(@))\n"
    $(AMDFWTOOL) \
    	$(AMDFW_COMMON_ARGS) \
+		$(OPT_APOB_NV_SIZE) \
+		$(OPT_APOB_NV_BASE) \
    	--location $(shell printf "%#x" $(CONFIG_PICASSO_FW_B_POSITION)) \
    	--anywhere \
    	--output $@