Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34365 )
Change subject: fix grub and tianocore make files
......................................................................
Patch Set 1:
Thank you for fetching my mistake. Commits should be for independent changes, so I factored the GRUB change out into [1] with you as author and your Signed-off-by line.
Please amend this commit to be just for TianoCore, and explain in the commit message, why the `all` target is gone. (The commit hash can be changed in the Kconfig menu, so it should be compatible.)
[1]: https://review.coreboot.org/c/coreboot/+/34366
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34365
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I321d4abdc955a9f4bc4ee2f3d95ccbc020898d0a
Gerrit-Change-Number: 34365
Gerrit-PatchSet: 1
Gerrit-Owner: Pim Bombeeck
pimbombeeck@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Pim Bombeeck
pimbombeeck@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 16 Jul 2019 11:50:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment