Attention is currently required from: Hung-Te Lin, Jason Glenesk, Philipp Hug, Furquan Shaikh, Marshall Dawson, Aaron Durbin, ron minnich, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49332 )
Change subject: memlayout: Store region sizes as separate symbols
......................................................................
Patch Set 2:
(3 comments)
File src/include/memlayout.h:
https://review.coreboot.org/c/coreboot/+/49332/comment/b5f1cde7_29cf5cd2
PS2, Line 36: #define RECORD_SIZE(name) \
Macros with multiple statements should be enclosed in a do - while loop
https://review.coreboot.org/c/coreboot/+/49332/comment/bcdec55e_208238a7
PS2, Line 36: #define RECORD_SIZE(name) \
macros should not use a trailing semicolon
https://review.coreboot.org/c/coreboot/+/49332/comment/d627148d_ba7d5739
PS2, Line 53: #define REGION_END(name, addr) \
Macros with complex values should be enclosed in parentheses
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49332
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd89708ca9bd3937d0db7308959231106a6aa373
Gerrit-Change-Number: 49332
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 13 Jan 2021 00:06:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment