build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44727 )
Change subject: soc/mediatek/mt8192: Do dramc analog init setting
......................................................................
Patch Set 19:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44727/19/src/soc/mediatek/mt8192/dr...
File src/soc/mediatek/mt8192/dramc_ana_init_config.c:
https://review.coreboot.org/c/coreboot/+/44727/19/src/soc/mediatek/mt8192/dr...
PS19, Line 1182: dq_pick = (tr->dq_semi_open == 1) ? 0 : (data_rate/2) ;
space prohibited before semicolon
https://review.coreboot.org/c/coreboot/+/44727/19/src/soc/mediatek/mt8192/dr...
PS19, Line 1206: (ca_pick * 2 *(tr->ca_ckdiv4_en + 1))) ?
need consistent spacing around '*' (ctx:WxV)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44727
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53b30a2bbed5acb363f85f7cbc7f255fdbc52304
Gerrit-Change-Number: 44727
Gerrit-PatchSet: 19
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: huayang duan
huayangduan@gmail.com
Gerrit-Comment-Date: Fri, 06 Nov 2020 09:41:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment