[coreboot-gerrit] [XS] Change in coreboot[master]: ec/starlabs/merlin/ite: Print version mismatches

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76380?usp=email )

(

8 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
 )Change subject: ec/starlabs/merlin/ite: Print version mismatches
......................................................................

ec/starlabs/merlin/ite: Print version mismatches

If the version of the EC firmware in coreboot doesn't match
the firmware that the EC is running, print the versions.

Signed-off-by: Sean Rhodes 
Change-Id: I55c09b8d5ffe8ca9135384c823d005b55cfd83d9
Reviewed-on: https://review.coreboot.org/c/coreboot/+/76380
Reviewed-by: Matt DeVillier 
Tested-by: build bot (Jenkins) 
---
M src/ec/starlabs/merlin/ite.c
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Matt DeVillier: Looks good to me, approved

diff --git a/src/ec/starlabs/merlin/ite.c b/src/ec/starlabs/merlin/ite.c
index 0f807de..62210ad 100644
--- a/src/ec/starlabs/merlin/ite.c
+++ b/src/ec/starlabs/merlin/ite.c
@@ -79,10 +79,13 @@
     * that have CCG6, present on devices with TBT, but have a manual
     * flag for devices without it.
     */
+	uint16_t ec_version = ec_get_version();
+
    if (CONFIG(EC_STARLABS_MIRROR_SUPPORT) &&
    	(CONFIG(SOC_INTEL_COMMON_BLOCK_TCSS) || get_uint_option("mirror_flag", 0)) &&
-		(ec_get_version() != CONFIG_EC_STARLABS_MIRROR_VERSION))	{
-		printk(BIOS_ERR, "ITE: System and EC ROM version mismatch.\n");
+		(ec_version != CONFIG_EC_STARLABS_MIRROR_VERSION)) {
+		printk(BIOS_ERR, "ITE: EC version 0x%x doesn't match coreboot version 0x%x.\n",
+			ec_version, CONFIG_EC_STARLABS_MIRROR_VERSION);
    	ec_mirror_with_count();
    }
 }