Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Nick Vaccaro, Tarun, sridhar siricilla.
Hello Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Nick Vaccaro, Tarun, build bot (Jenkins), sridhar siricilla,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80361?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed: Code-Review+2 by sridhar siricilla, Verified+1 by build bot (Jenkins)
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: soc/intel/cmn/sa: Refactor SA common code ......................................................................
soc/intel/cmn/sa: Refactor SA common code
Leverages common SA header definitions for Host Bridge registers. Renames DSM_BASE_ADDR_REG to BDSM and DPR_REG to DPR for brevity.
Additionally, made some minor code alignment corrections while adding newer macros in the header file.
TEST= Build and boot successful on google/screebo.
Change-Id: I476f213d75a0978336b3749a5ba1499107eb2238 Signed-off-by: Subrata Banik subratabanik@google.com --- M src/soc/intel/alderlake/include/soc/systemagent.h M src/soc/intel/alderlake/systemagent.c M src/soc/intel/common/block/include/intelblocks/systemagent.h M src/soc/intel/common/block/systemagent/systemagent_def.h M src/soc/intel/meteorlake/include/soc/systemagent.h M src/soc/intel/meteorlake/systemagent.c 6 files changed, 32 insertions(+), 41 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/80361/4