Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43604 )
Change subject: lib: Add ASan support to romstage on x86 arch ......................................................................
Patch Set 7: Code-Review+1
Patch Set 5:
Patch Set 5:
I tested ASan on the Asrock B85M Pro4, and it still boots. However, I can't see anything about asan in the logs...
Thank you for testing Angel. The fact that it boots tells me that it is still working. And the fact that you cannot see anything Asan related in the logs means that there are no errors ASan has found. You can try (if you like) to introduce an error by yourself (for instance define a stack array of size n and access it at location n + m). This should then trigger ASan and you should find something in the log.
Alright, will try.
Patch Set 5:
(3 comments)
I have tested this patch train on mc_apl3. It boots up fine with no issues. I have introduced an out-of-bounds error in src/mainboard/siemens/mc_apl1/romstage.c which ASan was able to find.
Could you please push the example you used so that I can get some inspiration from it?