Attention is currently required from: Mario Scheithauer, Paul Menzel, Werner Zeh.
Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76175?usp=email )
Change subject: mb/siemens/mc_apl5: Correct the Tx signal from SATA port 0
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/siemens/mc_apl1/variants/mc_apl5/mainboard.c:
https://review.coreboot.org/c/coreboot/+/76175/comment/b545cbcb_0bf5d8de :
PS3, Line 43: (0x00 << 16)
bad fault... […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76175?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I965960004ca44f1b37b16ce6484000fa7fd8ad90
Gerrit-Change-Number: 76175
Gerrit-PatchSet: 4
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Jan Samek
jan.samek@siemens.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Thu, 29 Jun 2023 11:06:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mario Scheithauer
mario.scheithauer@siemens.com
Comment-In-Reply-To: Jan Samek
jan.samek@siemens.com
Gerrit-MessageType: comment