Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45740 )
Change subject: drivers/spi: Add BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES config
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45740/4/src/drivers/spi/Kconfig
File src/drivers/spi/Kconfig:
https://review.coreboot.org/c/coreboot/+/45740/4/src/drivers/spi/Kconfig@56
PS4, Line 56: config BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY
`grep` is your best friend 😜
Will be keeping the BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY config for now. I don't want to split out the macro into different stages in the spi/Makefile.inc file right now. Also, Nico is looking into the possibility of removing the BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES/BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY config for older x86 boards: https://review.coreboot.org/c/coreboot/+/44196/8//COMMIT_MSG#19 so we can clean up the config at that point.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45740
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3aef8be702f55873233610b8e20d0662aa951ca7
Gerrit-Change-Number: 45740
Gerrit-PatchSet: 4
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 29 Sep 2020 17:22:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment