[coreboot-gerrit] Change in coreboot[master]: soc/mediatek/mt8192: add clkbuf and srclken_rc MT6359P driver

[Ran Bi (Code Review)]

Attention is currently required from: Joel Kitching, Roger Lu, Yu-Ping Wu, Yidi Lin, Yuchen Huang.
Ran Bi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46878 )

Change subject: soc/mediatek/mt8192: add clkbuf and srclken_rc MT6359P driver
......................................................................

Patch Set 65:

(5 comments)

File src/soc/mediatek/mt8192/srclken_rc.c:

https://review.coreboot.org/c/coreboot/+/46878/comment/79687b61_3f8ece23 
PS64, Line 13: (
> No need for parentheses.

Done

https://review.coreboot.org/c/coreboot/+/46878/comment/0aa17614_1b3257f9 
PS64, Line 104: 0x0
> Align with DCXO_STABLE_TIME

Done

https://review.coreboot.org/c/coreboot/+/46878/comment/b0faae88_5d4a3f03 
PS64, Line 278: )
> Move ")" right after 16.

Done

https://review.coreboot.org/c/coreboot/+/46878/comment/a1cfe4ad_9339db75 
PS64, Line 354: 0
> No initialization.

Done

https://review.coreboot.org/c/coreboot/+/46878/comment/d8b96284_f730b967 
PS64, Line 365: retry--
> Sorry I was wrong. This should be "--retry", so that after the last failure, 'retry' will be 0.

I suppose it's correct to use "retry--". For example, if retry=1, we will have 10us delay at least.