Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33452 )
Change subject: soc/fsp_broadwell_de: Configure serial port UPDs correctly ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/33452/1/src/soc/intel/fsp_broadwell_de/fsp/c... File src/soc/intel/fsp_broadwell_de/fsp/chipset_fsp_util.c:
https://review.coreboot.org/#/c/33452/1/src/soc/intel/fsp_broadwell_de/fsp/c... PS1, Line 69: SerialPortControllerInit0
You might want to init the controller even if CONSOLE_SERIAL is disabled.
The SerialPortConfigure is used to enabled/disable the onboard serial UART. This setting is not depending on CONSOLE_SERIAL. What do you mean?
The SerialPortType value is used for CONSOLE_SERIAL. Value of 0 will disable FSP console output.