Tom Hiller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44510 )
Change subject: Intel GBE 82579LM bincfg set and spec
......................................................................
Patch Set 4:
Patch Set 2: Code-Review+1
(1 comment)
Looks pretty good to me, did you test this by comparing what it generated to your actual GbE?
If it was identical, we can probably merge this, or if it wasn't identical did you test on hw?
I tested internet conductivity, speed test was the same and appropriate device identification. I did not test PXE or Boot Agent to ensure they were fully disabled nor did I test Wake on LAN. tlaurion of osresearch/heads also verified it is functional and is being included in the heads build.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44510
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I377cbe2f77f2aef39f452dc6511a0ea6b2015963
Gerrit-Change-Number: 44510
Gerrit-PatchSet: 4
Gerrit-Owner: Tom Hiller
thrilleratplay@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tom Hiller
thrilleratplay@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 23 Aug 2020 14:31:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment