Yuchen He has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76025?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for FastPkgCRampDisableSa dt option ......................................................................
mb/{cfl,cml,whl}: Use true/false macros for FastPkgCRampDisableSa dt option
The true/false macros give the reader a better understanding about how the option should be used. Thus, replace 0/1 with false/true.
While on it, remove the quotes from the option name and from the value.
Coffeelake, Cometlake and Whiskeylake mainboards which use that option were changed by the following command ran from the top level directory.
dt_line="chip soc/intel/cannonlake" && \ option="FastPkgCRampDisableSa" && \ grep -r "${dt_line}" src/mainboard | \ cut -d ':' -f 1 | \ xargs sed -i'' -e "s/"${option}".*=.*"1"/${option} = true/g" -e "s/"${option}".*=.*"0"/${option} = false/g"
Change-Id: I985de7c542dae51f01e661bbfb4b9cbb938b2c3a Signed-off-by: lilacious yuchenhe126@gmail.com --- M src/mainboard/google/hatch/variants/dratini/overridetree.cb M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/jinlon/overridetree.cb M src/mainboard/google/hatch/variants/mushu/overridetree.cb M src/mainboard/purism/librem_cnl/devicetree.cb 5 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/76025/1
diff --git a/src/mainboard/google/hatch/variants/dratini/overridetree.cb b/src/mainboard/google/hatch/variants/dratini/overridetree.cb index 9880935..78b19af 100644 --- a/src/mainboard/google/hatch/variants/dratini/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dratini/overridetree.cb @@ -25,7 +25,7 @@ register "SlowSlewRateForGt" = "2" register FastPkgCRampDisableIa = true register FastPkgCRampDisableGt = true - register "FastPkgCRampDisableSa" = "1" + register FastPkgCRampDisableSa = true
# Intel Common SoC Config #+-------------------+---------------------------+ diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb index 0150fcc..afa83d0 100644 --- a/src/mainboard/google/hatch/variants/hatch/overridetree.cb +++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb @@ -22,7 +22,7 @@ register "SlowSlewRateForSa" = "2" register FastPkgCRampDisableIa = true register FastPkgCRampDisableGt = true - register "FastPkgCRampDisableSa" = "1" + register FastPkgCRampDisableSa = true
# Intel Common SoC Config #+-------------------+---------------------------+ diff --git a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb index f4f6ffc..7b08649 100644 --- a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb +++ b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb @@ -25,7 +25,7 @@ register "SlowSlewRateForGt" = "2" register FastPkgCRampDisableIa = true register FastPkgCRampDisableGt = true - register "FastPkgCRampDisableSa" = "1" + register FastPkgCRampDisableSa = true
# Intel Common SoC Config #+-------------------+---------------------------+ diff --git a/src/mainboard/google/hatch/variants/mushu/overridetree.cb b/src/mainboard/google/hatch/variants/mushu/overridetree.cb index eba388d..bbdae13 100644 --- a/src/mainboard/google/hatch/variants/mushu/overridetree.cb +++ b/src/mainboard/google/hatch/variants/mushu/overridetree.cb @@ -22,7 +22,7 @@ register "SlowSlewRateForSa" = "2" register FastPkgCRampDisableIa = true register FastPkgCRampDisableGt = true - register "FastPkgCRampDisableSa" = "1" + register FastPkgCRampDisableSa = true
register "power_limits_config" = "{ .tdp_pl1_override = 25, diff --git a/src/mainboard/purism/librem_cnl/devicetree.cb b/src/mainboard/purism/librem_cnl/devicetree.cb index c6fffed..e3d93f4 100644 --- a/src/mainboard/purism/librem_cnl/devicetree.cb +++ b/src/mainboard/purism/librem_cnl/devicetree.cb @@ -13,7 +13,7 @@
register FastPkgCRampDisableIa = true register FastPkgCRampDisableGt = true - register "FastPkgCRampDisableSa" = "1" + register FastPkgCRampDisableSa = true register "FastPkgCRampDisableFivr" = "1"
register "SlowSlewRateForIa" = "3" # fast/16