Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44276 )
Change subject: drivers/spi/tpm: Re-organize the TPM Initialization
......................................................................
Patch Set 2:
Patch Set 2:
Are you aware of Jes' work (CB:43741) or did the two of you just accidentally implement the same thing at the same time? This series is doing a bunch of things that I thought were handled better in Jes' version, I'm not sure if those were intentional changes?
I was aware of the requirement to cache the firmware version, but was not aware of the CL CB:43741. If the shared goals between these 2 CLs i.e. parsing and caching the CR50 Firmware version, can be split out as a separate CL, then we can drop this CL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44276
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I94fef8ed813f4c0482b23ba513465faaf1ceae9f
Gerrit-Change-Number: 44276
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 06 Aug 2020 23:29:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment