Attention is currently required from: Arthur Heymans, Dmitry Ponamorev, Michał Żygowski, Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Kyösti Mälkki, Patrick Rudolph, King Sumo.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57668 )
Change subject: soc/intel/baytrail,denverton_ns: Call setup_lapic()
......................................................................
Patch Set 10: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57668/comment/2ded4944_855c583c
PS10, Line 7: soc/intel/baytrail,denverton_ns: Call setup_lapic()
I checked Braswell out of curiosity (the code for Bay Trail and Braswell is pretty similar) and saw that CB:29290 already added the `setup_lapic()` call. Would be nice to reference that commit here.
Patchset:
PS3:
Thanks for reminding, I will take over this commit.
Seems to be done?
File src/soc/intel/denverton_ns/cpu.c:
https://review.coreboot.org/c/coreboot/+/57668/comment/a40276c9_accbfb96
PS10, Line 24: #include <cpu/x86/lapic.h>
nit: move between `#include <cpu/intel/common/common.h>` and `#include <device/device.h>`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57668
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iafbfb733d0be546e0e2fba937fd1d262785aa54d
Gerrit-Change-Number: 57668
Gerrit-PatchSet: 10
Gerrit-Owner: Dmitry Ponamorev
dponamorev@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: King Sumo
kingsumos@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Dmitry Ponamorev
dponamorev@gmail.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Michal Motyl
michalx.motyl@intel.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: King Sumo
kingsumos@gmail.com
Gerrit-Comment-Date: Tue, 14 Dec 2021 09:10:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Arthur Heymans
arthur.heymans@9elements.com
Comment-In-Reply-To: Dmitry Ponamorev
dponamorev@gmail.com
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment