Attention is currently required from: Jakub Czapiga. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59491 )
Change subject: libpayload: Add CBMEM_IMD_ENTRY support to coreboot tables parser ......................................................................
Patch Set 1:
(2 comments)
File payloads/libpayload/include/cbmem_id.h:
PS1: Rather than duplicate this, do we just want to move commonlib/cbmem_id.h to commonlib/bsd/ (and change the license, since it doesn't really contain more than you copied here anyway)?
File payloads/libpayload/libc/coreboot.c:
https://review.coreboot.org/c/coreboot/+/59491/comment/f101e75e_2c416618 PS1, Line 275: switch (cbmem_entry->id) { Could you take this opportunity to convert all the others that currently use lb_cbmem_ref (and call get_cbmem_addr() here) to use these entries as well? Then we could eventually get rid of some of that pointless duplication in the tables.