[coreboot-gerrit] [S] Change in coreboot[master]: ACPI: Add acpigen_write_PTC()

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Lance Zhao, Tim Wawrzynczak.

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74473 )

Change subject: ACPI: Add acpigen_write_PTC()
......................................................................

ACPI: Add acpigen_write_PTC()

Change-Id: Ibaf2d7105e7a5da8a50ef32b682978ff55fe31e0
Signed-off-by: Kyösti Mälkki 
---
M src/acpi/acpigen.c
M src/include/acpi/acpigen.h
2 files changed, 31 insertions(+), 11 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/74473/1

diff --git a/src/acpi/acpigen.c b/src/acpi/acpigen.c
index d308930..d613bec 100644
--- a/src/acpi/acpigen.c
+++ b/src/acpi/acpigen.c
@@ -711,7 +711,7 @@
    acpigen_emit_stream(stream, ARRAY_SIZE(stream));
 }

-void acpigen_write_empty_PTC(void)
+void acpigen_write_PTC(uint8_t duty_width, uint8_t duty_offset, uint16_t p_cnt)
 {
 /*
    Name (_PTC, Package (0x02)
@@ -719,31 +719,35 @@
    	ResourceTemplate ()
    	{
    		Register (FFixedHW,
-				0x00,               // Bit Width
-				0x00,               // Bit Offset
-				0x0000000000000000, // Address
+				0x00,               // Duty Width
+				0x00,               // Duty Offset
+				0x0000000000000000, // P_CNT IO Address
    			,)
    	},

ResourceTemplate ()
    	{
    		Register (FFixedHW,
-				0x00,               // Bit Width
-				0x00,               // Bit Offset
-				0x0000000000000000, // Address
+				0x00,               // Duty Width
+				0x00,               // Duty Offset
+				0x0000000000000000, // P_CNT IO Address
    			,)
    	}
    })
 */
    acpi_addr_t addr = {
-		.space_id    = ACPI_ADDRESS_SPACE_FIXED,
-		.bit_width   = 0,
-		.bit_offset  = 0,
+		.bit_width   = duty_width,
+		.bit_offset  = duty_offset,
    	.access_size = ACPI_ACCESS_SIZE_UNDEFINED,
-		.addrl       = 0,
+		.addrl       = p_cnt,
    	.addrh       = 0,
    };

+	if (addr.addrl != 0)
+		addr.space_id = ACPI_ADDRESS_SPACE_IO;
+	else
+		addr.space_id = ACPI_ADDRESS_SPACE_FIXED;
+
    acpigen_write_name("_PTC");
    acpigen_write_package(2);

@@ -756,6 +760,11 @@
    acpigen_pop_len();
 }

+void acpigen_write_empty_PTC(void)
+{
+	acpigen_write_PTC(0, 0, 0);
+}
+
 static void __acpigen_write_method(const char *name, uint8_t flags)
 {
    acpigen_emit_byte(METHOD_OP);
diff --git a/src/include/acpi/acpigen.h b/src/include/acpi/acpigen.h
index ae50143..180e937 100644
--- a/src/include/acpi/acpigen.h
+++ b/src/include/acpi/acpigen.h
@@ -431,6 +431,7 @@
 void acpigen_write_PPC_NVS(void);
 void acpigen_write_empty_PCT(void);
 void acpigen_write_empty_PTC(void);
+void acpigen_write_PTC(uint8_t duty_width, uint8_t duty_offset, uint16_t p_cnt);
 void acpigen_write_PRW(u32 wake, u32 level);
 void acpigen_write_STA(uint8_t status);
 void acpigen_write_STA_ext(const char *namestring);