Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier.
Nick Kochlowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85719?usp=email )
Change subject: soc/amd/phoenix: Remove outdated TODO comments ......................................................................
soc/amd/phoenix: Remove outdated TODO comments
Delete the "TODO: Update for Phoenix" comment from files that have already been updated in the previous chained patches.
Change-Id: I137dbba5094ae8cbf842b45d6137c5b0528e5413 Signed-off-by: Nicolas Kochlowski nickkochlowski@gmail.com --- M src/mainboard/amd/birman/devicetree_phoenix_opensil.cb M src/soc/amd/phoenix/Kconfig M src/soc/amd/phoenix/Makefile.mk M src/soc/amd/phoenix/acpi.c M src/soc/amd/phoenix/chip.h 5 files changed, 0 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/85719/1
diff --git a/src/mainboard/amd/birman/devicetree_phoenix_opensil.cb b/src/mainboard/amd/birman/devicetree_phoenix_opensil.cb index d84a010..ed2edc6 100644 --- a/src/mainboard/amd/birman/devicetree_phoenix_opensil.cb +++ b/src/mainboard/amd/birman/devicetree_phoenix_opensil.cb @@ -1,7 +1,5 @@ # SPDX-License-Identifier: GPL-2.0-only
-# TODO: Update for birman - chip soc/amd/phoenix register "common_config.espi_config" = "{ .std_io_decode_bitmap = ESPI_DECODE_IO_0x80_EN | ESPI_DECODE_IO_0X2E_0X2F_EN | ESPI_DECODE_IO_0X60_0X64_EN, diff --git a/src/soc/amd/phoenix/Kconfig b/src/soc/amd/phoenix/Kconfig index b15c12d..a62f8d7 100644 --- a/src/soc/amd/phoenix/Kconfig +++ b/src/soc/amd/phoenix/Kconfig @@ -1,7 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only
# TODO: Evaluate what can be moved to a common directory -# TODO: Update for Phoenix
config SOC_AMD_PHOENIX_BASE bool diff --git a/src/soc/amd/phoenix/Makefile.mk b/src/soc/amd/phoenix/Makefile.mk index 7713fad..b7fddbe 100644 --- a/src/soc/amd/phoenix/Makefile.mk +++ b/src/soc/amd/phoenix/Makefile.mk @@ -1,7 +1,6 @@ # SPDX-License-Identifier: BSD-3-Clause
# TODO: Move as much as possible to common -# TODO: Update for Phoenix
ifeq ($(CONFIG_SOC_AMD_PHOENIX_BASE),y)
diff --git a/src/soc/amd/phoenix/acpi.c b/src/soc/amd/phoenix/acpi.c index 1475b61..0f0ec26 100644 --- a/src/soc/amd/phoenix/acpi.c +++ b/src/soc/amd/phoenix/acpi.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* TODO: Update for Phoenix */ /* TODO: See what can be made common */
/* ACPI - create the Fixed ACPI Description Tables (FADT) */ diff --git a/src/soc/amd/phoenix/chip.h b/src/soc/amd/phoenix/chip.h index 07b0dab..771f30c 100644 --- a/src/soc/amd/phoenix/chip.h +++ b/src/soc/amd/phoenix/chip.h @@ -1,7 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* TODO: Update for Phoenix */ - #ifndef PHOENIX_CHIP_H #define PHOENIX_CHIP_H