Attention is currently required from: Angel Pons, Felix Held, Werner Zeh.
Lean Sheng Tan has posted comments on this change by Lean Sheng Tan. ( https://review.coreboot.org/c/coreboot/+/85780?usp=email )
Change subject: Fix up CFR's open issues
......................................................................
Patch Set 4:
(2 comments)
File src/drivers/option/cfr.c:
https://review.coreboot.org/c/coreboot/+/85780/comment/c7bea721_6276dce1?usp... :
PS3, Line 32: char *data;
Remove this line
Done
https://review.coreboot.org/c/coreboot/+/85780/comment/88fdacee_1d665929?usp... :
PS3, Line 42: *data = current + sizeof(*cfr_str);
Fix applied.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85780?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id66808382b93e32c58024462c18b20c2a89d6d23
Gerrit-Change-Number: 85780
Gerrit-PatchSet: 4
Gerrit-Owner: Lean Sheng Tan
tanleansheng@outlook.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 26 Dec 2024 23:35:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com