Denis Carikli (GNUtoo@no-log.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3281
-gerrit
commit 094589b27e13251929956f43c274376b1488029f Author: Denis 'GNUtoo' Carikli GNUtoo@no-log.org Date: Fri May 24 03:37:01 2013 +0200
southbridge/intel/i82801gx: Make compilation possible with CONFIG_SMM_TSEG
The fix is modelled after src/cpu/x86/smm/smihandler.c which ifdefs smi_release_lock().
Change-Id: Icdc6d039b34a1d95d0e607419bba2484d21abc5e Signed-off-by: Denis 'GNUtoo' Carikli GNUtoo@no-log.org --- src/southbridge/intel/i82801gx/smihandler.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/src/southbridge/intel/i82801gx/smihandler.c b/src/southbridge/intel/i82801gx/smihandler.c index f199b84..8e67f79 100644 --- a/src/southbridge/intel/i82801gx/smihandler.c +++ b/src/southbridge/intel/i82801gx/smihandler.c @@ -332,12 +332,14 @@ static void southbridge_smi_sleep(unsigned int node, smm_state_save_area_t *stat default: printk(BIOS_DEBUG, "SMI#: ERROR: SLP_TYP reserved\n"); break; }
+#if !CONFIG_SMM_TSEG /* Unlock the SMI semaphore. We're currently in SMM, and the semaphore * will never be unlocked because the next outl will switch off the CPU. * This might open a small race between the smi_release_lock() and the outl() * for other SMI handlers. Not sure if this could cause trouble. */ if (slp_typ == 5) smi_release_lock(); +#endif
/* Write back to the SLP register to cause the originally intended * event again. We need to set BIT13 (SLP_EN) though to make the