Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42839 )
Change subject: superio/nuvoton: Avoid NULL pointer dereference
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42839/3/src/superio/nuvoton/npcd378...
File src/superio/nuvoton/npcd378/superio.c:
https://review.coreboot.org/c/coreboot/+/42839/3/src/superio/nuvoton/npcd378...
PS3, Line 410: {
It seems not relevant because there is already NULL check for scope in the function superio_common_fill_ssdt_generator. The scope NULL check is only applied to acpigen_write_scope call.
What I mean is that adding a null check in this function also prevents warnings about `dev` being null in all `npcd378_ssdt_*` functions called from here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42839
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc253c63aadef1c0ecb116a38b608f64f80abc79
Gerrit-Change-Number: 42839
Gerrit-PatchSet: 4
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 29 Jun 2020 15:35:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: John Zhao
john.zhao@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment