Attention is currently required from: Nico Huber, Sridhar Siricilla, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49891 )
Change subject: southbridge/intel: Add dependency to ME_REGION_ALLOW_CPU_READ_ACCESS
......................................................................
Patch Set 3:
(2 comments)
File src/southbridge/intel/common/firmware/Kconfig:
https://review.coreboot.org/c/coreboot/+/49891/comment/854e5801_cbaaed7f
PS3, Line 60: default y if SOC_INTEL_CSE_LITE_SKU
Now that you are doing an override here, you can drop: https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/intel/common/bloc...
https://review.coreboot.org/c/coreboot/+/49891/comment/bca34496_34cf6df4
PS3, Line 61: depends on HAVE_IFD_BIN
Still need `default n` here i.e. this config will default to n for all cases !SOC_INTEL_CSE_LITE_SKU
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49891
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I680a23e27ae2bf4d85bf919134c47882f308af56
Gerrit-Change-Number: 49891
Gerrit-PatchSet: 3
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 27 Jan 2021 18:56:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment