Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42226 )
Change subject: mb/google/zork: Enable psp_verstage
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42226/6/src/mainboard/google/zork/K...
File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/42226/6/src/mainboard/google/zork/K...
PS6, Line 128: 0xFF031040
Can you provide the command you used to calculate these so they can be double checked? Also if someo […]
Sure. This is the start of the region in the fmap table with 0x40 added for the cbfs header.
I'm working on getting rid of these and will be updating verstage to find them with cbfs. That needs to happen in the next couple of weeks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42226
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6a12c2074d7c84c0cb766393c66f5eff29a58d5
Gerrit-Change-Number: 42226
Gerrit-PatchSet: 6
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 25 Jun 2020 23:56:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment