[coreboot-gerrit] Change in ...coreboot[master]: libpayload: Don't try to use invalid row count

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30092 )

Change subject: libpayload: Don't try to use invalid row count
......................................................................

Patch Set 1:

(1 comment)
> Are you sure this is the right fix? I'd argue that a console with 0 rows is an illegal console anyway, so ...

Same sentiment here.  I'm curious where it began to leave the rails.

https://review.coreboot.org/#/c/30092/1/payloads/libpayload/drivers/video/vi... 
File payloads/libpayload/drivers/video/video.c:

https://review.coreboot.org/#/c/30092/1/payloads/libpayload/drivers/video/vi... 
PS1, Line 90: console->rows <= 0
Just to be complete, maybe (console->rows <= 0 || console->columns <= 0)?  Granted, it's a solution in search of a problem...