Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42831 )
Change subject: soc/amd/picasso: Use cbfs to locate the AMD firmware ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42831/2/src/soc/amd/picasso/psp_ver... File src/soc/amd/picasso/psp_verstage/psp_verstage.h:
https://review.coreboot.org/c/coreboot/+/42831/2/src/soc/amd/picasso/psp_ver... PS2, Line 32: #define POSTCODE_AMD_FW_MISSING 0xc9 inconsistent capitalization
https://review.coreboot.org/c/coreboot/+/42831/2/src/soc/amd/picasso/psp_ver... File src/soc/amd/picasso/psp_verstage/psp_verstage.c:
https://review.coreboot.org/c/coreboot/+/42831/2/src/soc/amd/picasso/psp_ver... PS2, Line 89: (uint32_t)boot_dev.base); I believe you want an absolute address from the spi mapping, correct? The address returned from locate_amdfw() already is based off boot_dev because the fmap_locate_area_as_rdev() uses the boot device.