Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47863 )
Change subject: mb/google/volteer: Update Eldrid USB2 port settings in overridetree ......................................................................
mb/google/volteer: Update Eldrid USB2 port settings in overridetree
1. Disable M.2 WWAN and Type-A Port A1 2. Change register 4 to 3 and tuning USB2 Port1 eye diagram 3. Lower camera driving
BUG=b:169105751 Signed-off-by: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Change-Id: I6b8a5c0d5e814de232d79a43354f5ec0220fc5ea Reviewed-on: https://review.coreboot.org/c/coreboot/+/47863 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/volteer/variants/eldrid/overridetree.cb 1 file changed, 14 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb index 72571c0..51bc991 100644 --- a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb +++ b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb @@ -58,12 +58,22 @@ }, }, }" - #These settings improve the USB2 Port1 eye diagram + + #Disable Type-A Port A1 + register "usb2_ports[1]" = "USB2_PORT_EMPTY" + + #Disable M.2 WWAN + register "usb2_ports[2]" = "USB2_PORT_EMPTY" + + #improve the USB2 Port1 eye diagram + register "usb2_ports[3]" = "USB2_PORT_SHORT(OC_SKIP)" + + #lower camera driving register "usb2_ports[4]" = "{ .enable = 1, - .tx_bias = 7, - .tx_emp_enable = 7, - .pre_emp_bias = 3, + .tx_bias = 0, + .tx_emp_enable = 0, + .pre_emp_bias = 0, .pre_emp_bit = 0, }"