Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35188 )
Change subject: soc/skylake: lock AES-NI MSR
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35188/5/src/soc/intel/skylake/cpu.c
File src/soc/intel/skylake/cpu.c:
https://review.coreboot.org/c/coreboot/+/35188/5/src/soc/intel/skylake/cpu.c...
PS5, Line 428: MSR_FEATURE_CONFIG
Before reading the MSR, don't you need to check CPUID to determine if the MSR is really supported?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35188
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97a0d3b1b9b0452e929ca07d29c03237b413e521
Gerrit-Change-Number: 35188
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Mon, 02 Sep 2019 06:05:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment