[coreboot-gerrit] [XL] Change in coreboot[main]: soc/intel/ptl: Do initial Panther Lake SoC commit till ramstage

[Saurabh Mishra (Code Review)]

Attention is currently required from: Jérémy Compostella, Kapil Porwal, Pranava Y N, Subrata Banik.

Saurabh Mishra has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83798?usp=email )

Change subject: soc/intel/ptl: Do initial Panther Lake SoC commit till ramstage
......................................................................

Patch Set 75:

(4 comments)

File src/soc/intel/pantherlake/pmc.c:

https://review.coreboot.org/c/coreboot/+/83798/comment/c7ae8665_26d795a9?usp... :
PS71, Line 29: reg
> can you please check if the `reg` is non-zero ?

Hi, you mean to implment a check in this function?

File src/soc/intel/pantherlake/pmutil.c:

https://review.coreboot.org/c/coreboot/+/83798/comment/db238e8c_ef24c46a?usp... :
PS71, Line 152:
> please add a NULL check

Added. Done.

File src/soc/intel/pantherlake/retimer.c:

https://review.coreboot.org/c/coreboot/+/83798/comment/12a0b12c_d6c92fe2?usp... :
PS71, Line 19: 
             : 	for (uint8_t i = 0; i < MAX_TYPE_C_PORTS; i++) {
>

Hi, declaring variables of the same type together in for loop is accepted in c.
Here, variable i is "uint8_t " type, while ec_port variable is declared "int".
This will give an error since mixing types in the initialization section is not allowed.

Can be used as below?
````
  for (int i = 0, ec_port = 0; i < MAX_TYPE_C_PORTS; i++) {
````

File src/soc/intel/pantherlake/systemagent.c:

https://review.coreboot.org/c/coreboot/+/83798/comment/8d6c72a9_ca918a54?usp... :
PS71, Line 33: // PCH_PRESERVERD covers:
             : 		// TraceHub SW BAR, PMC MBAR, SPI BAR0, SerialIo BAR in ACPI mode
             : 		// eSPI LGMR BAR, eSPI2 SEGMR BAR, TraceHub MTB BAR, TraceHub FW BAR
             : 		// IOE PMC BAR, Tracehub RTIT BAR (SOC), HECI{1,2,3} BAR0
             : 		// see fsp/ClientOneSiliconPkg/Fru/MtlSoc/Include/PchReservedResources.h
> I understand that you are concerned about the accessibility of this code. […]

Sure, i have removed the comments.