Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36143 )
Change subject: arch/x86/boot.c: Pass arguments when running programs
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36143/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36143/2//COMMIT_MSG@9
PS2, Line 9: Payloads can use coreboot tables passed on the stack.
only on x86_32 arguments are pushed onto the stack
Correct. Calling through a function pointer is subject to the ABI the compiler is targeting.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36143
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0f44e9e1992221e02c49d0492cdd2a3d9013560
Gerrit-Change-Number: 36143
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 22 Oct 2019 17:55:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment