Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32218 )
Change subject: Revert "mb/google/sarien: Enable ISH on arcada, disable on sarien"
......................................................................
Patch Set 3:
Please update the CL description to say this is for testing only, otherwise it is confusing to other people that see this revert and think something is wrong.
Also is there a reason you uploaded this change instead of carrying it locally?
Performing this change on the chromium tree of coreboot would probably be more effective for testing purposes as that is what actually builds (https://chromium.git.corp.google.com/chromiumos/third_party/coreboot/+/refs/...)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32218
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8f8edf7bba230cb707c1d9dadf1b3de11c1e60da
Gerrit-Change-Number: 32218
Gerrit-PatchSet: 3
Gerrit-Owner: Li1 Feng
li1.feng@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Jett Rink
jettrink@google.com
Gerrit-Reviewer: Li1 Feng
li1.feng@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 08 Apr 2019 13:26:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment