Attention is currently required from: Wonkyu Kim.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74389 )
Change subject: src/arch/x86 Add CPU frequency APIs
......................................................................
Patch Set 1:
(1 comment)
File src/arch/x86/cpu_common.c:
https://review.coreboot.org/c/coreboot/+/74389/comment/a933996f_df7361da
PS1, Line 6: #include <intelblocks/msr.h>
No intel specific includes under arch/.
Also, from what I remember, even within Intel, interpretation of frequency related MSRs are very model-specific.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74389
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8eb4397b4a8d4058af1b5c67716ee625261c4e2a
Gerrit-Change-Number: 74389
Gerrit-PatchSet: 1
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Comment-Date: Fri, 14 Apr 2023 03:31:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment