Attention is currently required from: Jason Glenesk, Raul Rangel, Martin L Roth, Matt DeVillier, Fred Reitberger, Karthik Ramasubramanian, Felix Held.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71208 )
Change subject: soc/amd/common/psp_verstage: Report HSP Secure State
......................................................................
Patch Set 8:
(1 comment)
File src/soc/amd/common/psp_verstage/psp_verstage.c:
https://review.coreboot.org/c/coreboot/+/71208/comment/c8521070_bf79c70d
PS7, Line 165: if (!CONFIG(SOC_AMD_COMMON_BLOCK_PSP_INCLUDES_HSP))
: return;
This is redundant with the check below. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71208
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4875d1732f22783a90434329188192b106168f4
Gerrit-Change-Number: 71208
Gerrit-PatchSet: 8
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jon Murphy
jpmurphy@google.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 13 Jan 2023 18:34:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment