Attention is currently required from: Paul Menzel, Nicholas Chin.
char has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70623 )
Change subject: mb/acer: Add Acer Swift 3 (Intel Kaby Lake) ......................................................................
Patch Set 12:
(9 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/70623/comment/a4ea31a8_3486fef4 PS5, Line 14: Turned tabs into spaces
I think the preferred style is tabs over spaces? Doesn't seem to be explicitly documented but the ch […]
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/70623/comment/61fa24c0_07f4c510 PS9, Line 7: Adding
Add
Done
https://review.coreboot.org/c/coreboot/+/70623/comment/6812c2c5_808ecce4 PS9, Line 7: Adding new mainboard Acer Swift 3
Please add a prefix, and maybe name the SoC: […]
Done
https://review.coreboot.org/c/coreboot/+/70623/comment/1b1b68ed_777d0dd1 PS9, Line 10: Only tested with payload SeaBIOS. Can not verify battery charge as my
Please add a blank line between paragraphs.
Done
https://review.coreboot.org/c/coreboot/+/70623/comment/e4eff34f_d5ff4536 PS9, Line 10: SeaBIOS
Which version?
Done
https://review.coreboot.org/c/coreboot/+/70623/comment/16d4e80a_21d872f7 PS9, Line 12: as vendor option ROM is too large for : SeaBIOS to use
What error do you get?
Do you want the error in the commit message? The error is: WARNING - Unable to allocate resource at deploy_romfile:1791 Looking into the SeaBIOS source code, it doesn't support chained option roms.
https://review.coreboot.org/c/coreboot/+/70623/comment/277eb234_f472f03f PS9, Line 14: Added
Add
Done
Patchset:
PS12: Should be good for review, no longer WIP.
File src/mainboard/acer/swift3-SF314-52G-55WQ/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/70623/comment/15b894d8_d8264d95 PS5, Line 215: device lapic 0 on end
As of commit 69cd729c0c (mb/*: Remove lapic from devicetree) this line should be removed
Seems to need both the cpu_cluster and the lapic lines to boot.