Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44457 )
Change subject: util/intelp2m: Add support for Cannonlake-LP SoCs
......................................................................
Patch Set 2:
Patch Set 2: Code-Review+1
(11 comments)
It looks great. Thanks for this work.
Some notes:
I recommend inheriting function from the sunrise through the interface.
In this case, it is easier to understand which functions are the same as the
parent (Please see platforms/lbg/macro.go)
After this, please generate gpio.h again and compare this to gpio.h before fixes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44457
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86296697ee892af7aa0818fb608b6d68fad2f307
Gerrit-Change-Number: 44457
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 14 Aug 2020 08:29:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment