Attention is currently required from: Lance Zhao, Won Chung, Nick Vaccaro, Benson Leung, Prashant Malani.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59401 )
Change subject: ec/google/chromeec: Add PLD to EC conn in ACPI table
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59401/comment/a44d257c_b99234cb
PS1, Line 10: TEST=emerge-brya coreboot
I believe you also tested this on a brya by dumping the SSDT and verifying the PLD object is written out under the EC CON* devices.
File src/ec/google/chromeec/ec_acpi.c:
https://review.coreboot.org/c/coreboot/+/59401/comment/d1eee97a_09e3042a
PS1, Line 125: struct drivers_usb_acpi_config *config;
:
: config = NULL;
nit:
`struct drivers_usb_acpi_config *config = NULL;`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59401
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc56ecd4e8954ffaace3acd9528a064b5fa2cf6f
Gerrit-Change-Number: 59401
Gerrit-PatchSet: 1
Gerrit-Owner: Won Chung
wonchung@google.com
Gerrit-Reviewer: Benson Leung
bleung@chromium.org
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Prashant Malani
pmalani@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Won Chung
wonchung@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Benson Leung
bleung@chromium.org
Gerrit-Attention: Prashant Malani
pmalani@chromium.org
Gerrit-Comment-Date: Thu, 18 Nov 2021 17:52:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment