Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48641 )
Change subject: mb/google/dedede: Update Boten setting for USI PEN detection. ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48641/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48641/1//COMMIT_MSG@9 PS1, Line 9: Update devicetree and gpio driving of boten that enable stylus Can you please add the following details as well:
PEN detect signal is not dual-routed on Boten. Since the gpio_keys kernel driver expects the pad to be owned by GPIO controller (i.e. configured for GPIO IRQ), it cannot be configured for ACPI (i.e. SCI). Thus, this change updates the GPIO configuration for GPP_C12 to PAD_CFG_GPI_GPIO_DRIVER and device tree entry for PENH device to use WAKEUP_ROUTE_GPIO_IRQ. Additionally, the signal is marked as active low in the device tree entry to indicate to the kernel driver that the signal is inverted.
Not dual routing the signal results in wake source not being added to eventlog when pen removal results in wake from S0ix.
https://review.coreboot.org/c/coreboot/+/48641/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48641/1/src/mainboard/google/dedede... PS1, Line 119: Can you please replace the spaces with tabs like it is for other lines in this file?