Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31950 )
Change subject: device/pciexp_device: Add set_subsystem() for pciexp device
......................................................................
Patch Set 5:
One more thing, MPC configuration bit BT. These PCIe root ports may, in some configurations, appear with Type 0 header. The way I see it, datasheets only describe the register layout for the typical case of Type 1 header, and forget to mention it does not apply when this MPC.BT is set.
Do you agree? I don't have a convenient way to test this.
As a conclusion: we should not hard-wire these PCIe root ports to use register 0x94 for SSID programming, but sometimes need to use 0x2c instead. I'll do a followup once we have this merged.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31950
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5fbed39ed448baf11f0e0786ce0ee94741d57237
Gerrit-Change-Number: 31950
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 19 Mar 2019 17:50:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment