Attention is currently required from: Nico Huber, Angel Pons, Arthur Heymans.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46959 )
Change subject: sb/intel/lynxpoint/acpi: Add missing USB ports
......................................................................
Patch Set 12: Code-Review+2
(1 comment)
File src/southbridge/intel/lynxpoint/acpi/xhci.asl:
https://review.coreboot.org/c/coreboot/+/46959/comment/7c276dc8_ba94af49
PS11, Line 346: Device (SSP6) { Name (_ADR, 15) } // USB Port 15
Yeah, and 486708 Rev2.0 section `5.21 xHCI Controller (D20:F0)` also says the following: […]
Ah yes, that would be very unusual, and probably not technically "USB" standard, to have a port that only supports SS but not HS...
+1 to more usage of acpigen vs. static ASL
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46959
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id66f169070cdfe3a6d166ca18916d4ddaf4a5fea
Gerrit-Change-Number: 46959
Gerrit-PatchSet: 12
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 23 Feb 2021 15:50:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment
