18 Jul
2024
18 Jul
'24
6:14 p.m.
Attention is currently required from: Elyes Haouas, Martin L Roth, Nico Huber.
Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83452?usp=email )
Change subject: Makefile.mk: Reorganize CFLAGS_common ......................................................................
Patch Set 6: Code-Review+1
(1 comment)
File Makefile.mk:
https://review.coreboot.org/c/coreboot/+/83452/comment/46686881_01438744?usp... : PS4, Line 507: # Options controlling the kind of output
I'll remove those comments, but in that case, the sorting will not be easy to understand. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/83452?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3216ef2e0b3cd25f343939d5b9ef932f2f91e56c
Gerrit-Change-Number: 83452
Gerrit-PatchSet: 6
Gerrit-Owner: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Elyes Haouas ehaouas@noos.fr
Gerrit-Comment-Date: Fri, 19 Jul 2024 01:14:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Elyes Haouas ehaouas@noos.fr