Attention is currently required from: Arthur Heymans, Nicholas Sudsgaard.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80727?usp=email )
Change subject: include/device/azalia_device.h: Fix incorrect bit shift ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80727/comment/8ca37c53_691be374 : PS2, Line 7: include/device/azalia_device.h: Fix incorrect bit shift please add Intel HDA Specification as reference (Rev. 1.0a, Figure 74)
https://review.coreboot.org/c/coreboot/+/80727/comment/49d69d1d_9e4d63bb : PS2, Line 9: TEST=Timeless build using AZALIA_PIN_DESC() and without now produce the : same binary.
The connected pins have these values: […]
When porting that board I decoded the values with that wrong 27 bit shift. That is why everything is wrong now ofc. I will push a patch to correct the board tomorrow.
Not sure about the order, though. Your patch first or mine? binaries will change either way