20 Aug
2020
20 Aug
'20
4:03 p.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44646 )
Change subject: vendorcode/google/chromeos: Introduce helper for CSE board reset ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44646/3/src/vendorcode/google/chrom... File src/vendorcode/google/chromeos/cse_board_reset.c:
https://review.coreboot.org/c/coreboot/+/44646/3/src/vendorcode/google/chrom... PS3, Line 14: FULL_RST | SYS_RST It might be helpful to have a comment indicating that this is to ensure that AP makes a trip to S5 (i.e. full power reset) when SYSRST# is asserted by the EC.
--
To view, visit https://review.coreboot.org/c/coreboot/+/44646
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8078e2436d1d58a650bf7b0cf38b5bb89a474187
Gerrit-Change-Number: 44646
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Sridhar Siricilla sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 20 Aug 2020 23:03:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment