23 Jul
2020
23 Jul
'20
12:23 p.m.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43764 )
Change subject: mb/google/volteer/variants/volteer: Add gpio-keys ACPI node for PENH ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43764/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/volteer/gpio.c:
https://review.coreboot.org/c/coreboot/+/43764/3/src/mainboard/google/voltee... PS3, Line 33: PAD_CFG_GPI_GPIO_DRIVER I've usually used _GPI_APIC for this before, but I guess the kernel must know how to handle this? Do you get the stylus tools to pop up in the UI when you eject the pen?
--
To view, visit https://review.coreboot.org/c/coreboot/+/43764
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida3217a5b156320856ce3302c2623eba2230f28d
Gerrit-Change-Number: 43764
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Levin levinale@google.com
Gerrit-Reviewer: Alex Levin levinale@chromium.org
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 23 Jul 2020 19:23:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment