Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33532 )
Change subject: vboot: remove vboot_handoff_get_recovery_reason ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/#/c/33532/1/src/security/vboot/bootmode.c File src/security/vboot/bootmode.c:
https://review.coreboot.org/#/c/33532/1/src/security/vboot/bootmode.c@95 PS1, Line 95: * 3. Checks recovery request in handoff for stages post-cbmem.
Not correct anymore.
Done
https://review.coreboot.org/#/c/33532/1/src/security/vboot/bootmode.c@96 PS1, Line 96: For non-CBMEM stages,
This too.
Done
https://review.coreboot.org/#/c/33532/1/src/security/vboot/bootmode.c@114 PS1, Line 114: For stages where CBMEM might not be online,
This comment needs update too?
Done
https://review.coreboot.org/#/c/33532/1/src/security/vboot/vboot_common.h File src/security/vboot/vboot_common.h:
https://review.coreboot.org/#/c/33532/1/src/security/vboot/vboot_common.h@57 PS1, Line 57: functions
Just one function now.
Done